Pin utfbom and go-homedir to v1.0.0 and remove the explicit dependency on x/crypto master #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues today with a build pipeline that has this project as a dependency. Some changes to
x/crypto
weren't valid with some of my other dependencies, and the explicit pinning to master here causes pain upstream (having to use depoverrides
). I don't see any reason why go-autorest needs to always be pinned to master, so I've removed this -dep
will use the most recent valid version it can.While I was at it, I also added specific versions (
v1.0.0
) for utfbom and go-homedir.None of these changes actually change the dependencies in any way, as seen with the simple diff on the
Gopkg.lock
file. This just helps other repos which import this project.As for checking the boxes that this is an "urgent bug fix" and warrants its own release, that's up to you - I altered the changelog in a separate commit. But given this is dealing with how projects import go-autorest, I think it would be prudent to tag a patch release with these changes.
As part of submitting, please make sure you can make the following assertions:
dev
branch, except in the case of urgent bug fixes warranting their own release.master
, I've updated CHANGELOG.md to address the changes I'm making.